Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
Merge branch 'sb/gpg-plug-fd-leak' into maint
author
Junio C Hamano
<gitster@pobox.com>
Thu, 7 Feb 2013 23:14:54 +0000
(15:14 -0800)
committer
Junio C Hamano
<gitster@pobox.com>
Thu, 7 Feb 2013 23:14:54 +0000
(15:14 -0800)
We forgot to close the file descriptor reading from "gpg" output,
killing "git log --show-signature" on a long history.
* sb/gpg-plug-fd-leak:
gpg: close stderr once finished with it in verify_signed_buffer()
gpg-interface.c
patch
|
blob
|
history
raw
(from parent 1:
427c6d0
)
diff --git
a/gpg-interface.c
b/gpg-interface.c
index 0863c618007a02fa20c27b62614de8a554128d0c..5f142f619855ccd664a84be366bf6877a48e6da4 100644
(file)
--- a/
gpg-interface.c
+++ b/
gpg-interface.c
@@
-130,8
+130,10
@@
int verify_signed_buffer(const char *payload, size_t payload_size,
write_in_full(gpg.in, payload, payload_size);
close(gpg.in);
- if (gpg_output)
+ if (gpg_output)
{
strbuf_read(gpg_output, gpg.err, 0);
+ close(gpg.err);
+ }
ret = finish_command(&gpg);
unlink_or_warn(path);