gitweb.git
Merge branch 'cm/diff-check-at-eol'Junio C Hamano Tue, 30 Nov 2010 01:52:31 +0000 (17:52 -0800)

Merge branch 'cm/diff-check-at-eol'

* cm/diff-check-at-eol:
diff --check: correct line numbers of new blank lines at EOF

Merge branch 'ak/apply-non-git-epoch'Junio C Hamano Tue, 30 Nov 2010 01:52:31 +0000 (17:52 -0800)

Merge branch 'ak/apply-non-git-epoch'

* ak/apply-non-git-epoch:
apply: handle patches with funny filename and colon in timezone
apply: Recognize epoch timestamps with : in the timezone

Merge branch 'tc/smart-http-post-redirect'Junio C Hamano Tue, 30 Nov 2010 01:52:30 +0000 (17:52 -0800)

Merge branch 'tc/smart-http-post-redirect'

* tc/smart-http-post-redirect:
smart-http: Don't change POST to GET when following redirect

gitweb: document $per_request_config betterJonathan Nieder Mon, 29 Nov 2010 00:19:08 +0000 (18:19 -0600)

gitweb: document $per_request_config better

Global variables $my_url, $my_uri and $base_url have subtle interactions
that need to be desribed, and can be influenced most cleanly by
$per_request_config.

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Acked-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

gitweb: selectable configurations that change with... Jakub Narebski Thu, 25 Nov 2010 18:43:59 +0000 (19:43 +0100)

gitweb: selectable configurations that change with each request

Allow selecting whether configuration file should be (re)parsed on each
request (the default, for backward compatibility with configurations that
change per session, see commit 7f425db (gitweb: allow configurations that
change with each request, 2010-07-30)), or whether should it be parsed only
once (for performance speedup for persistent environments, though currently
only FastCGI is able to make use of it, when flexibility is not important).

You can also have configuration file parsed only once, but have parts of
configuration (re)evaluated once per each request.

This is done by introducing $per_request_config variable: if set to code
reference, this code would be run once per request, while config file would
be parsed only once. For example gitolite's contrib/gitweb/gitweb.conf
fragment mentioned in 7f425db could be rewritten as

our $per_request_config = sub {
$ENV{GL_USER} = ($cgi && $cgi->remote_user) || "gitweb";
};

to make use of this feature.

If $per_request_config is not a code reference, it is taken to be boolean
variable, to choose between running config file for each request
(flexibility), and running config file only once (performance in
persistent environments).

The default value for $per_request_config is 1 (true), which means that
old configuration that require to change per session (like gitolite's)
will keep working.

While at it, make it so evaluate_git_version() is run only once.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Use reflog in 'pull --rebase . foo'Martin von Zweigbergk Sat, 13 Nov 2010 22:58:22 +0000 (23:58 +0100)

Use reflog in 'pull --rebase . foo'

Since c85c792 (pull --rebase: be cleverer with rebased upstream
branches, 2008-01-26), "git pull --rebase" has used the reflog to try to
rebase from the old upstream onto the new upstream.

Make this work if the local repository is explicitly passed on the
command line as in 'git pull --rebase . foo'.

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Acked-by: Santi Béjar <santi@agolina.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

rebase: only show stat if configured to trueMartin von Zweigbergk Tue, 9 Nov 2010 20:59:00 +0000 (21:59 +0100)

rebase: only show stat if configured to true

If rebase.stat is set to true, a diffstat should be displayed. If it is
not set, it should default to false. However, if it is explicitly set to
false (or other value), a diffstat is still displayed, which is probably
not what most users would expect. Show diffstat only if it is set
to true.

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

entry.c: remove "checkout-index" from error messagesNguyễn Thái Ngọc Duy Sun, 28 Nov 2010 04:36:38 +0000 (11:36 +0700)

entry.c: remove "checkout-index" from error messages

Back then when entry.c was part of checkout-index (or checkout-cache
at that time [1]). It makes sense to print the command name in error
messages. Nowadays entry.c is in libgit and can be used by any
commands, printing "git checkout-index: blah" does no more than
confusion. The error messages without it still give enough information.

[1] 12dccc1 (Make fiel checkout function available to the git library - 2005-06-05)

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

http-fetch: rework url handlingTay Ray Chuan Thu, 25 Nov 2010 08:21:10 +0000 (16:21 +0800)

http-fetch: rework url handling

Do away with a second url variable, rewritten_url, and make url
non-const. This is safe because the functions called with url (ie.
get_http_walker() and walker_fetch()) do not modify it (ie. marked with
const char *).

Also, replace code that adds a trailing slash with a call to
str_end_url_with_slash().

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

http-push: add trailing slash at arg-parse time, instea... Tay Ray Chuan Thu, 25 Nov 2010 08:21:09 +0000 (16:21 +0800)

http-push: add trailing slash at arg-parse time, instead of later on

That way, we don't have to update repo->path and repo->path_len again
after adding the trailing slash.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

http-push: check path length before using itTay Ray Chuan Thu, 25 Nov 2010 08:21:08 +0000 (16:21 +0800)

http-push: check path length before using it

We use path_len to skip the base url/path, but we do not know for sure
if path does indeed contain the base url/path. Check if this is so.

Helped-by: Johnathan Nieder <jrnieder@gmail.com>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

http-push: Normalise directory names when pushing to... Tay Ray Chuan Thu, 25 Nov 2010 08:21:07 +0000 (16:21 +0800)

http-push: Normalise directory names when pushing to some WebDAV servers

Fix a bug when pushing to WebDAV servers which do not use a trailing
slash for collection names. The previous implementation fails to see
that the requested resource "refs/" is the same resource as "refs"
and loads every reference twice (once for refs/ and once for refs).

This implementation normalises every collection name by appending a
trailing slash if necessary.

This can be tested with old versions of Apache (such as the WebDAV
server of GMX, Apache 2.0.63).

Based-on-patch-by: Gabriel Corona <gabriel.corona@enst-bretagne.fr>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

http-backend: use end_url_with_slash()Tay Ray Chuan Thu, 25 Nov 2010 08:21:06 +0000 (16:21 +0800)

http-backend: use end_url_with_slash()

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

url: add str wrapper for end_url_with_slash()Tay Ray Chuan Thu, 25 Nov 2010 08:21:05 +0000 (16:21 +0800)

url: add str wrapper for end_url_with_slash()

Helped-by: Johnathan Nieder <jrnieder@gmail.com>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

shift end_url_with_slash() from http.[ch] to url.[ch]Tay Ray Chuan Thu, 25 Nov 2010 08:21:04 +0000 (16:21 +0800)

shift end_url_with_slash() from http.[ch] to url.[ch]

This allows non-http/curl users to access it too (eg. http-backend.c).

Update include headers in end_url_with_slash() users too.

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t5550-http-fetch: add test for http-fetchTay Ray Chuan Thu, 25 Nov 2010 08:21:03 +0000 (16:21 +0800)

t5550-http-fetch: add test for http-fetch

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

t5550-http-fetch: add missing '&&'Tay Ray Chuan Thu, 25 Nov 2010 08:21:02 +0000 (16:21 +0800)

t5550-http-fetch: add missing '&&'

Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'en/and-cascade-tests'Junio C Hamano Fri, 26 Nov 2010 22:45:37 +0000 (14:45 -0800)

Merge branch 'en/and-cascade-tests'

* en/and-cascade-tests:
t7300: add a missing SYMLINKS prerequisite

t7300: add a missing SYMLINKS prerequisiteJohannes Sixt Thu, 25 Nov 2010 08:03:39 +0000 (09:03 +0100)

t7300: add a missing SYMLINKS prerequisite

The test fails on Windows since 2dec68c (tests: add missing &&, batch 2).

Even though this test allocates and leaves behind files, subsequent tests
do not depend on this, so it is safe to just skip it.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'cb/maint-orphan-merge-noclobber'Junio C Hamano Wed, 24 Nov 2010 23:55:36 +0000 (15:55 -0800)

Merge branch 'cb/maint-orphan-merge-noclobber'

* cb/maint-orphan-merge-noclobber:
do not overwrite untracked during merge from unborn branch

Merge branch 'ao/send-email-irt'Junio C Hamano Wed, 24 Nov 2010 23:55:32 +0000 (15:55 -0800)

Merge branch 'ao/send-email-irt'

* ao/send-email-irt:
git-send-email.perl: make initial In-Reply-To apply only to first email
t9001: send-email interation with --in-reply-to and --chain-reply-to

Merge branch 'jk/add-e-doc'Junio C Hamano Wed, 24 Nov 2010 23:55:29 +0000 (15:55 -0800)

Merge branch 'jk/add-e-doc'

* jk/add-e-doc:
docs: give more hints about how "add -e" works
docs: give more hints about how "add -e" works

Merge branch 'rs/opt-help-text'Junio C Hamano Wed, 24 Nov 2010 23:55:19 +0000 (15:55 -0800)

Merge branch 'rs/opt-help-text'

* rs/opt-help-text:
verify-tag: document --verbose
branch: improve --verbose description
archive: improve --verbose description
Describe various forms of "be quiet" using OPT__QUIET
add OPT__FORCE
add description parameter to OPT__QUIET
add description parameter to OPT__DRY_RUN
add description parameter to OPT__VERBOSE

Merge branch 'kb/maint-rebase-autosquash'Junio C Hamano Wed, 24 Nov 2010 23:55:15 +0000 (15:55 -0800)

Merge branch 'kb/maint-rebase-autosquash'

* kb/maint-rebase-autosquash:
rebase: teach --autosquash to match on sha1 in addition to message
rebase: better rearranging of fixup!/squash! lines with --autosquash

Merge branch 'mm/phrase-remote-tracking'Junio C Hamano Wed, 24 Nov 2010 23:55:05 +0000 (15:55 -0800)

Merge branch 'mm/phrase-remote-tracking'

* mm/phrase-remote-tracking:
git-branch.txt: mention --set-upstream as a way to change upstream configuration
user-manual: remote-tracking can be checked out, with detached HEAD
user-manual.txt: explain better the remote(-tracking) branch terms
Change incorrect "remote branch" to "remote tracking branch" in C code
Change incorrect uses of "remote branch" meaning "remote-tracking"
Change "tracking branch" to "remote-tracking branch"
everyday.txt: change "tracking branch" to "remote-tracking branch"
Change remote tracking to remote-tracking in non-trivial places
Replace "remote tracking" with "remote-tracking"
Better "Changed but not updated" message in git-status

Merge branch 'en/and-cascade-tests'Junio C Hamano Wed, 24 Nov 2010 23:51:49 +0000 (15:51 -0800)

Merge branch 'en/and-cascade-tests'

* en/and-cascade-tests: (25 commits)
t4124 (apply --whitespace): use test_might_fail
t3404: do not use 'describe' to implement test_cmp_rev
t3404 (rebase -i): introduce helper to check position of HEAD
t3404 (rebase -i): move comment to description
t3404 (rebase -i): unroll test_commit loops
t3301 (notes): use test_expect_code for clarity
t1400 (update-ref): use test_must_fail
t1502 (rev-parse --parseopt): test exit code from "-h"
t6022 (renaming merge): chain test commands with &&
test-lib: introduce test_line_count to measure files
tests: add missing &&, batch 2
tests: add missing &&
Introduce sane_unset and use it to ensure proper && chaining
t7800 (difftool): add missing &&
t7601 (merge-pull-config): add missing &&
t7001 (mv): add missing &&
t6016 (rev-list-graph-simplify-history): add missing &&
t5602 (clone-remote-exec): add missing &&
t4026 (color): remove unneeded and unchained command
t4019 (diff-wserror): add lots of missing &&
...

Conflicts:
t/t7006-pager.sh

docs: default to more modern toolsetJeff King Fri, 19 Nov 2010 17:54:24 +0000 (12:54 -0500)

docs: default to more modern toolset

When the ASCIIDOC8 and ASCIIDOC_NO_ROFF knobs were built,
many people were still on asciidoc 7 and using older
versions of docbook-xsl. These days, even the almost
2-year-old Debian stable needs these knobs turned.

So let's turn them by default. The new knobs ASCIIDOC7 and
ASCIIDOC_ROFF can be used to get the old behavior if people
are on older systems.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'maint'Junio C Hamano Wed, 24 Nov 2010 21:24:49 +0000 (13:24 -0800)

Merge branch 'maint'

* maint:
imap-send: link against libcrypto for HMAC and others
git-send-email.perl: Deduplicate "to:" and "cc:" entries with names
mingw: do not set errno to 0 on success

Merge branch 'jl/maint-pull-tags-doc' into maintJunio C Hamano Wed, 24 Nov 2010 20:47:42 +0000 (12:47 -0800)

Merge branch 'jl/maint-pull-tags-doc' into maint

* jl/maint-pull-tags-doc:
pull: Remove --tags option from manpage

Merge branch 'kb/maint-diff-ws-check' into maintJunio C Hamano Wed, 24 Nov 2010 20:47:27 +0000 (12:47 -0800)

Merge branch 'kb/maint-diff-ws-check' into maint

* kb/maint-diff-ws-check:
diff: handle lines containing only whitespace and tabs better
test-lib: extend test_decode_color to handle more color codes

Merge branch 'jm/mailmap' into maintJunio C Hamano Wed, 24 Nov 2010 20:47:18 +0000 (12:47 -0800)

Merge branch 'jm/mailmap' into maint

* jm/mailmap:
t4203: do not let "git shortlog" DWIM based on tty
t4203 (mailmap): stop hardcoding commit ids and dates
mailmap: fix use of freed memory

Merge branch 'tr/maint-git-repack-tmpfile' into maintJunio C Hamano Wed, 24 Nov 2010 20:47:10 +0000 (12:47 -0800)

Merge branch 'tr/maint-git-repack-tmpfile' into maint

* tr/maint-git-repack-tmpfile:
repack: place temporary packs under .git/objects/pack/

Merge branch 'jk/maint-apply-no-binary' into maintJunio C Hamano Wed, 24 Nov 2010 20:47:04 +0000 (12:47 -0800)

Merge branch 'jk/maint-apply-no-binary' into maint

* jk/maint-apply-no-binary:
apply: don't segfault on binary files with missing data

Merge branch 'jn/send-pack-error' into maintJunio C Hamano Wed, 24 Nov 2010 20:46:46 +0000 (12:46 -0800)

Merge branch 'jn/send-pack-error' into maint

* jn/send-pack-error:
send-pack: avoid redundant "pack-objects died with strange error"

Merge branch 'ak/submodule-sync' into maintJunio C Hamano Wed, 24 Nov 2010 20:46:40 +0000 (12:46 -0800)

Merge branch 'ak/submodule-sync' into maint

* ak/submodule-sync:
submodule sync: Update "submodule.<name>.url" for empty directories

Merge branch 'jk/maint-rev-list-nul' into maintJunio C Hamano Wed, 24 Nov 2010 20:46:32 +0000 (12:46 -0800)

Merge branch 'jk/maint-rev-list-nul' into maint

* jk/maint-rev-list-nul:
rev-list: handle %x00 NUL in user format

Merge branch 'cb/diff-fname-optim' into maintJunio C Hamano Wed, 24 Nov 2010 20:46:26 +0000 (12:46 -0800)

Merge branch 'cb/diff-fname-optim' into maint

* cb/diff-fname-optim:
diff: avoid repeated scanning while looking for funcname
do not search functions for patch ID
add rebase patch id tests

Merge branch 'jk/no-textconv-symlink' into maintJunio C Hamano Wed, 24 Nov 2010 20:46:20 +0000 (12:46 -0800)

Merge branch 'jk/no-textconv-symlink' into maint

* jk/no-textconv-symlink:
diff: don't use pathname-based diff drivers for symlinks

Merge branch 'dk/maint-blame-el' into maintJunio C Hamano Wed, 24 Nov 2010 20:46:17 +0000 (12:46 -0800)

Merge branch 'dk/maint-blame-el' into maint

* dk/maint-blame-el:
git-blame.el: Add (require 'format-spec)

Merge branch 'aw/git-p4-deletion' into maintJunio C Hamano Wed, 24 Nov 2010 20:46:14 +0000 (12:46 -0800)

Merge branch 'aw/git-p4-deletion' into maint

* aw/git-p4-deletion:
Fix handling of git-p4 on deleted files

Merge branch 'kf/post-receive-sample-hook' into maintJunio C Hamano Wed, 24 Nov 2010 20:45:39 +0000 (12:45 -0800)

Merge branch 'kf/post-receive-sample-hook' into maint

* kf/post-receive-sample-hook:
post-receive-email: ensure sent messages are not empty

Merge branch 'jk/repack-reuse-object' into maintJunio C Hamano Wed, 24 Nov 2010 20:45:07 +0000 (12:45 -0800)

Merge branch 'jk/repack-reuse-object' into maint

* jk/repack-reuse-object:
Documentation: pack.compression: explain how to recompress
repack: add -F flag to let user choose between --no-reuse-delta/object

Conflicts:
Documentation/git-repack.txt

Merge branch 'bc/fix-cherry-pick-root' into maintJunio C Hamano Wed, 24 Nov 2010 20:44:46 +0000 (12:44 -0800)

Merge branch 'bc/fix-cherry-pick-root' into maint

* bc/fix-cherry-pick-root:
builtin/revert.c: don't dereference a NULL pointer

Merge branch 'uk/fix-author-ident-sed-script' into... Junio C Hamano Wed, 24 Nov 2010 20:44:41 +0000 (12:44 -0800)

Merge branch 'uk/fix-author-ident-sed-script' into maint

* uk/fix-author-ident-sed-script:
get_author_ident_from_commit(): remove useless quoting

Merge branch 'ab/makefile-track-cc' into maintJunio C Hamano Wed, 24 Nov 2010 20:44:35 +0000 (12:44 -0800)

Merge branch 'ab/makefile-track-cc' into maint

* ab/makefile-track-cc:
Makefile: add CC to TRACK_CFLAGS

Merge branch 'mg/reset-doc' into maintJunio C Hamano Wed, 24 Nov 2010 20:44:26 +0000 (12:44 -0800)

Merge branch 'mg/reset-doc' into maint

* mg/reset-doc:
git-reset.txt: make modes description more consistent
git-reset.txt: point to git-checkout
git-reset.txt: use "working tree" consistently
git-reset.txt: reset --soft is not a no-op
git-reset.txt: reset does not change files in target
git-reset.txt: clarify branch vs. branch head

Merge branch 'tr/send-email-refuse-sending-unedited... Junio C Hamano Wed, 24 Nov 2010 20:44:12 +0000 (12:44 -0800)

Merge branch 'tr/send-email-refuse-sending-unedited-cover-letter' into maint

* tr/send-email-refuse-sending-unedited-cover-letter:
send-email: Refuse to send cover-letter template subject

imap-send: link against libcrypto for HMAC and othersDiego Elio Pettenò Wed, 24 Nov 2010 20:03:53 +0000 (21:03 +0100)

imap-send: link against libcrypto for HMAC and others

When using stricter linkers, such as GNU gold or Darwin ld, transitive
dependencies are not counted towards symbol resolution. If we don't link
imap-send to libcrypto, we'll have undefined references to the HMAC_*,
EVP_* and ERR_* functions families.

Signed-off-by: Diego Elio Pettenò <flameeyes@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git-send-email.perl: Deduplicate "to:" and "cc:" entrie... Joe Perches Sat, 20 Nov 2010 23:06:05 +0000 (15:06 -0800)

git-send-email.perl: Deduplicate "to:" and "cc:" entries with names

If an email address in the "to:" list is in the style
"First Last <email@domain.tld>", ie: not just a bare
address like "email@domain.tld", and the same named
entry style exists in the "cc:" list, the current
logic will not remove the entry from the "cc:" list.

Add logic to better deduplicate the "cc:" list by also
matching the email address with angle brackets.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

reflogs: clear flags properly in corner caseJeff King Mon, 22 Nov 2010 04:42:53 +0000 (23:42 -0500)

reflogs: clear flags properly in corner case

The reflog-walking mechanism is based on the regular
revision traversal. We just rewrite the parents of each
commit in fake_reflog_parent to point to the commit in the
next reflog entry instead of the real parents.

However, the regular revision traversal tries not to show
the same commit twice, and so sets the SHOWN flag on each
commit it shows. In a reflog, however, we may want to see
the same commit more than once if it appears in the reflog
multiple times (which easily happens, for example, if you do
a reset to a prior state).

The fake_reflog_parent function takes care of this by
clearing flags, including SHOWN. Unfortunately, it does so
at the very end of the function, and it is possible to
return early from the function if there is no fake parent to
set up (e.g., because we are at the very first reflog entry
on the branch). In such a case the flag is not cleared, and
the entry is skipped by the revision traversal machinery as
already shown.

You can see this by walking the log of a ref which is set to
its very first commit more than once (the test below shows
such a situation). In this case the reflog walk will fail to
show the entry for the initial creation of the ref.

We don't want to simply move the flag-clearing to the top of
the function; we want to make sure flags set during the
fake-parent installation are also cleared. Instead, let's
hoist the flag-clearing out of the fake_reflog_parent
function entirely. It's not really about fake parents
anyway, and the only caller is the get_revision machinery.

Reported-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

rebase --abort: do not update branch refMartin von Zweigbergk Sun, 21 Nov 2010 11:11:21 +0000 (12:11 +0100)

rebase --abort: do not update branch ref

If a non-interactive rebase of a ref fails at commit X and is aborted by
the user, the ref will be updated twice. First to point at X (with the
reflog message "rebase finished: $head_name onto $onto"), and then back
to $orig_head. It should not be updated at all.

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

mingw: do not set errno to 0 on successErik Faye-Lund Tue, 23 Nov 2010 19:53:08 +0000 (20:53 +0100)

mingw: do not set errno to 0 on success

Currently do_lstat always sets errno to 0 on success. This incorrectly
overwrites previous errors.

Fetch the error-code into a temporary variable instead, and assign that
to errno on failure.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

win32: use our own dirent.hErik Faye-Lund Tue, 23 Nov 2010 18:38:29 +0000 (19:38 +0100)

win32: use our own dirent.h

The mingw-runtime implemenation of opendir, readdir and closedir
sets errno to 0 on success, something that POSIX explicitly
forbids. 3ba7a06 ("A loose object is not corrupt if it cannot be
read due to EMFILE") introduce a dependency on this behaviour,
leading to a broken "git clone" on Windows.

compat/mingw.c contains an implementation of readdir, and
compat/msvc.c contains implementations of opendir and closedir.

Move these to compat/win32/dirent.[ch], and change to our own DIR
structure at the same time.

This provides a generic Win32-implementation of opendir, readdir
and closedir which works on both MinGW and MSVC and does not reset
errno, and as a result git clone is working again on Windows.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

msvc: opendir: handle paths ending with a slashErik Faye-Lund Tue, 23 Nov 2010 18:38:28 +0000 (19:38 +0100)

msvc: opendir: handle paths ending with a slash

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

win32: dirent: handle errorsErik Faye-Lund Tue, 23 Nov 2010 18:38:27 +0000 (19:38 +0100)

win32: dirent: handle errors

Previously all error conditions were ignored. Be nice, and set errno
when we should.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

msvc: opendir: do not start the searchErik Faye-Lund Tue, 23 Nov 2010 18:38:26 +0000 (19:38 +0100)

msvc: opendir: do not start the search

compat/mingw.c's readdir expects to be the one that starts the search,
and if it isn't, then the first entry will be missing or incorrect.

Fix this by removing the call to _findfirst, and initializing dd_handle
to INVALID_HANDLE_VALUE.

At the same time, make sure we use FindClose instead of _findclose,
which is symmetric to readdir's FindFirstFile. Take into account that
the find-handle might already be closed by readdir.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

msvc: opendir: allocate enough memoryErik Faye-Lund Tue, 23 Nov 2010 18:38:25 +0000 (19:38 +0100)

msvc: opendir: allocate enough memory

The defintion of DIR expects the allocating function to extend
dd_name by over-allocating. This is not currently done in our
implementation of opendir. Fix this.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

msvc: opendir: fix malloc-failureErik Faye-Lund Tue, 23 Nov 2010 18:38:24 +0000 (19:38 +0100)

msvc: opendir: fix malloc-failure

Previsouly, the code checked for malloc-failure after it had accessed
the returned pointer. Move the check a bit earlier to avoid segfault.

Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'ef/mingw-daemon'Junio C Hamano Wed, 24 Nov 2010 00:05:46 +0000 (16:05 -0800)

Merge branch 'ef/mingw-daemon'

* ef/mingw-daemon:
daemon: opt-out on features that require posix
daemon: make --inetd and --detach incompatible
daemon: use socklen_t
mingw: use poll-emulation from gnulib
mingw: import poll-emulation from gnulib
daemon: get remote host address from root-process
Improve the mingw getaddrinfo stub to handle more use cases
daemon: use full buffered mode for stderr
daemon: use run-command api for async serving
mingw: add kill emulation
mingw: support waitpid with pid > 0 and WNOHANG
mingw: use real pid
inet_ntop: fix a couple of old-style decls
compat: add inet_pton and inet_ntop prototypes
mingw: implement syslog
mingw: add network-wrappers for daemon

format-patch: page output with --stdoutTay Ray Chuan Tue, 23 Nov 2010 03:16:30 +0000 (11:16 +0800)

format-patch: page output with --stdout

Pass output through the pager if format-patch is run with --stdout. This
saves the user the trouble of running git with '-p' or piping through a
pager.

setup_pager() already checks if stdout is a tty, so we don't have to
worry about behaviour if the user redirects/pipes stdout. Paging can
also be disabled with the config

[pager]
format-patch = false

Add tests to check for these behaviour.

Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Tay Ray Chuan <rctay89@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

rebase: support --verifyMartin von Zweigbergk Mon, 22 Nov 2010 20:21:01 +0000 (21:21 +0100)

rebase: support --verify

Interactive rebase allows the '--verify' option to be passed, but it will
be ignored. Implement proper support for the option for both interactive
and non-interactive rebase by making it override any previous
'--no-verify'.

Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

remote-fd/ext: finishing touches after code reviewIlari Liusvaara Wed, 17 Nov 2010 17:15:34 +0000 (09:15 -0800)

remote-fd/ext: finishing touches after code review

When compiling with pthread support, transport-helper.c needs to include
necessary header files. Also fix a few error messages in remote-ext and
remote-fd programs, and a potential buffer underrun in remote-fd.

In the documentation, clarify how %G and %V are used; the old description
looked as if they take repository/vhost parameters, which was wrong.

Also fix AsciiDoc markup for the page title of remote-fd/remote-ext manpages,
and tweak the way how section headers are shown.

Signed-off-by: Ilari Liusvaara <ilari.liusvaara@elisanet.fi>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Update draft release notes to 1.7.4Junio C Hamano Thu, 18 Nov 2010 00:43:05 +0000 (16:43 -0800)

Update draft release notes to 1.7.4

Signed-off-by: Junio C Hamano <gitster@pobox.com>

Merge branch 'jl/maint-pull-tags-doc'Junio C Hamano Wed, 17 Nov 2010 23:02:35 +0000 (15:02 -0800)

Merge branch 'jl/maint-pull-tags-doc'

* jl/maint-pull-tags-doc:
pull: Remove --tags option from manpage

Merge branch 'kb/maint-submodule-savearg'Junio C Hamano Wed, 17 Nov 2010 23:02:12 +0000 (15:02 -0800)

Merge branch 'kb/maint-submodule-savearg'

* kb/maint-submodule-savearg:
submodule: only preserve flags across recursive status/update invocations
submodule: preserve all arguments exactly when recursing

Merge branch 'jk/missing-config'Junio C Hamano Wed, 17 Nov 2010 23:02:08 +0000 (15:02 -0800)

Merge branch 'jk/missing-config'

* jk/missing-config:
config: treat non-existent config files as empty

Merge branch 'kb/maint-diff-ws-check'Junio C Hamano Wed, 17 Nov 2010 23:01:47 +0000 (15:01 -0800)

Merge branch 'kb/maint-diff-ws-check'

* kb/maint-diff-ws-check:
diff: handle lines containing only whitespace and tabs better
test-lib: extend test_decode_color to handle more color codes

Merge branch 'bg/maint-gitweb-test-lib'Junio C Hamano Wed, 17 Nov 2010 23:01:37 +0000 (15:01 -0800)

Merge branch 'bg/maint-gitweb-test-lib'

* bg/maint-gitweb-test-lib:
t/gitweb-lib: Don't pass constant to decode_utf8

Conflicts:
t/gitweb-lib.sh

Merge branch 'jm/mailmap'Junio C Hamano Wed, 17 Nov 2010 23:01:26 +0000 (15:01 -0800)

Merge branch 'jm/mailmap'

* jm/mailmap:
t4203: do not let "git shortlog" DWIM based on tty
t4203 (mailmap): stop hardcoding commit ids and dates
mailmap: fix use of freed memory

Merge branch 'tr/maint-git-repack-tmpfile'Junio C Hamano Wed, 17 Nov 2010 23:01:23 +0000 (15:01 -0800)

Merge branch 'tr/maint-git-repack-tmpfile'

* tr/maint-git-repack-tmpfile:
repack: place temporary packs under .git/objects/pack/

Merge branch 'jk/maint-apply-no-binary'Junio C Hamano Wed, 17 Nov 2010 23:01:18 +0000 (15:01 -0800)

Merge branch 'jk/maint-apply-no-binary'

* jk/maint-apply-no-binary:
apply: don't segfault on binary files with missing data

Merge branch 'jk/push-progress'Junio C Hamano Wed, 17 Nov 2010 23:01:00 +0000 (15:01 -0800)

Merge branch 'jk/push-progress'

* jk/push-progress:
push: pass --progress down to git-pack-objects
t5523-push-upstream: test progress messages
t5523-push-upstream: add function to ensure fresh upstream repo
test_terminal: ensure redirections work reliably
test_terminal: catch use without TTY prerequisite
test-lib: allow test code to check the list of declared prerequisites
tests: test terminal output to both stdout and stderr
tests: factor out terminal handling from t7006

Merge branch 'tr/maint-merge-file-subdir'Junio C Hamano Wed, 17 Nov 2010 23:00:56 +0000 (15:00 -0800)

Merge branch 'tr/maint-merge-file-subdir'

* tr/maint-merge-file-subdir:
merge-file: correctly find files when called in subdir
prefix_filename(): safely handle the case where pfx_len=0

Merge branch 'jn/send-pack-error'Junio C Hamano Wed, 17 Nov 2010 23:00:51 +0000 (15:00 -0800)

Merge branch 'jn/send-pack-error'

* jn/send-pack-error:
send-pack: avoid redundant "pack-objects died with strange error"

Merge branch 'mg/make-prove'Junio C Hamano Wed, 17 Nov 2010 23:00:46 +0000 (15:00 -0800)

Merge branch 'mg/make-prove'

* mg/make-prove:
test: allow running the tests under "prove"

Merge branch 'kb/completion-checkout'Junio C Hamano Wed, 17 Nov 2010 23:00:42 +0000 (15:00 -0800)

Merge branch 'kb/completion-checkout'

* kb/completion-checkout:
completion: Support the DWIM mode for git checkout

Merge branch 'sg/completion'Junio C Hamano Wed, 17 Nov 2010 23:00:11 +0000 (15:00 -0800)

Merge branch 'sg/completion'

* sg/completion:
bash: support pretty format aliases
bash: support more 'git notes' subcommands and their options
bash: not all 'git bisect' subcommands make sense when not bisecting
bash: offer refs for 'git bisect start'

Merge branch 'sg/bisect'Junio C Hamano Wed, 17 Nov 2010 23:00:03 +0000 (15:00 -0800)

Merge branch 'sg/bisect'

* sg/bisect:
bisect: check for mandatory argument of 'bisect replay'
bisect: improve error msg of 'bisect reset' when original HEAD is deleted
bisect: improve error message of 'bisect log' while not bisecting

Merge branch 'ak/submodule-sync'Junio C Hamano Wed, 17 Nov 2010 22:59:54 +0000 (14:59 -0800)

Merge branch 'ak/submodule-sync'

* ak/submodule-sync:
submodule sync: Update "submodule.<name>.url" for empty directories

Merge branch 'jk/maint-rev-list-nul'Junio C Hamano Wed, 17 Nov 2010 22:59:33 +0000 (14:59 -0800)

Merge branch 'jk/maint-rev-list-nul'

* jk/maint-rev-list-nul:
rev-list: handle %x00 NUL in user format

Merge branch 'ks/no-textconv-symlink'Junio C Hamano Wed, 17 Nov 2010 22:59:27 +0000 (14:59 -0800)

Merge branch 'ks/no-textconv-symlink'

* ks/no-textconv-symlink:
blame,cat-file --textconv: Don't assume mode is ``S_IFREF | 0664''
blame,cat-file: Demonstrate --textconv is wrongly running converter on symlinks
blame,cat-file: Prepare --textconv tests for correctly-failing conversion program

Merge branch 'jn/gitweb-test'Junio C Hamano Wed, 17 Nov 2010 22:59:22 +0000 (14:59 -0800)

Merge branch 'jn/gitweb-test'

* jn/gitweb-test:
gitweb/Makefile: Include gitweb/config.mak
gitweb/Makefile: Add 'test' and 'test-installed' targets
t/gitweb-lib.sh: Add support for GITWEB_TEST_INSTALLED
gitweb: Move call to evaluate_git_version after evaluate_gitweb_config

Merge branch 'cb/diff-fname-optim'Junio C Hamano Wed, 17 Nov 2010 22:59:16 +0000 (14:59 -0800)

Merge branch 'cb/diff-fname-optim'

* cb/diff-fname-optim:
diff: avoid repeated scanning while looking for funcname
do not search functions for patch ID
add rebase patch id tests

Merge branch 'jk/no-textconv-symlink'Junio C Hamano Wed, 17 Nov 2010 22:59:10 +0000 (14:59 -0800)

Merge branch 'jk/no-textconv-symlink'

* jk/no-textconv-symlink:
diff: don't use pathname-based diff drivers for symlinks

Merge branch 'dk/maint-blame-el'Junio C Hamano Wed, 17 Nov 2010 22:59:04 +0000 (14:59 -0800)

Merge branch 'dk/maint-blame-el'

* dk/maint-blame-el:
git-blame.el: Add (require 'format-spec)

Merge branch 'maint'Junio C Hamano Wed, 17 Nov 2010 21:57:58 +0000 (13:57 -0800)

Merge branch 'maint'

* maint:
clean: remove redundant variable baselen
Documentation/git-pull: clarify configuration
Document that rev-list --graph triggers parent rewriting.
clean: avoid quoting twice
document sigchain api
Keep together options controlling the behaviour of diffcore-rename.
t3402: test "rebase -s<strategy> -X<opt>"

t6022: Use -eq not = to test output of wc -lBrian Gernhardt Mon, 8 Nov 2010 21:29:26 +0000 (16:29 -0500)

t6022: Use -eq not = to test output of wc -l

When comparing numbers such as "3" to "$(wc -l)", we should check for
numerical equality using -eq instead of string equality using = because
some implementations of wc output extra whitespace.

Signed-off-by: Brian Gernhardt <brian@gernhardtsoftware.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

clean: remove redundant variable baselenNguyễn Thái Ngọc Duy Mon, 15 Nov 2010 06:42:44 +0000 (13:42 +0700)

clean: remove redundant variable baselen

baselen used to be the result of common_prefix() when it was made
builtin. Since 1d8842d (Add 'fill_directory()' helper function for
directory traversal - 2009-05-14), its value will always be
zero. Remove it because it's no longer variable.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Provide 'git merge --abort' as a synonym to 'git reset... Johan Herland Tue, 9 Nov 2010 21:49:59 +0000 (22:49 +0100)

Provide 'git merge --abort' as a synonym to 'git reset --merge'

Teach 'git merge' the --abort option, which verifies the existence of
MERGE_HEAD and then invokes 'git reset --merge' to abort the current
in-progress merge and attempt to reconstruct the pre-merge state.

The reason for adding this option is to provide a user interface for
aborting an in-progress merge that is consistent with the interface
for aborting a rebase ('git rebase --abort'), aborting the application
of a patch series ('git am --abort'), and aborting an in-progress notes
merge ('git notes merge --abort').

The patch includes documentation and testcases that explain and verify
the various scenarios in which 'git merge --abort' can run. The
testcases also document the cases in which 'git merge --abort' is
unable to correctly restore the pre-merge state (look for the '###'
comments towards the bottom of t/t7609-merge-abort.sh).

This patch has been improved by the following contributions:
- Jonathan Nieder: Move test documentation into test_description

Thanks-to: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

cmd_merge(): Parse options before checking MERGE_HEADJohan Herland Tue, 9 Nov 2010 21:49:58 +0000 (22:49 +0100)

cmd_merge(): Parse options before checking MERGE_HEAD

Reorder the initial part of builtin/merge.c:cmd_merge() so that command-line
options are parsed _before_ we load the index and check for MERGE_HEAD
(and exits if it exists). This does not change the behaviour of 'git merge',
but is needed in preparation for the implementation of 'git merge --abort'
(which requires MERGE_HEAD to be present).

This patch has been improved by the following contributions:
- Junio C Hamano: fixup minor style issues

Thanks-to: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Provide 'git notes get-ref' to easily retrieve current... Johan Herland Tue, 9 Nov 2010 21:49:57 +0000 (22:49 +0100)

Provide 'git notes get-ref' to easily retrieve current notes ref

Script may use 'git notes get-ref' to easily retrieve the current notes ref.

Suggested-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: Add testcases for merging notes trees... Johan Herland Tue, 9 Nov 2010 21:49:56 +0000 (22:49 +0100)

git notes merge: Add testcases for merging notes trees at different fanouts

Notes trees may exist at different fanout levels internally. This
implementation detail should not be visible to the user, and it should
certainly not affect the merging of notes tree.

This patch adds testcases verifying the correctness of 'git notes merge'
when merging notes trees at different fanout levels.

This patch has been improved by the following contributions:
- Junio C Hamano: Portability: Don't string-compare 'wc -l' output

Thanks-to: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: Add another auto-resolving strategy... Johan Herland Sun, 14 Nov 2010 23:57:17 +0000 (00:57 +0100)

git notes merge: Add another auto-resolving strategy: "cat_sort_uniq"

This new strategy is similar to "concatenate", but in addition to
concatenating the two note candidates, this strategy sorts the resulting
lines, and removes duplicate lines from the result. This is equivalent to
applying the "cat | sort | uniq" shell pipeline to the two note candidates.

This strategy is useful if the notes follow a line-based format where one
wants to avoid duplicate lines in the merge result.

Note that if either of the note candidates contain duplicate lines _prior_
to the merge, these will also be removed by this merge strategy.

The patch also contains tests and documentation for the new strategy.

Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: --commit should fail if underlying... Johan Herland Tue, 9 Nov 2010 21:49:54 +0000 (22:49 +0100)

git notes merge: --commit should fail if underlying notes ref has moved

When manually resolving a notes merge, if the merging ref has moved since
the merge started, we should fail to complete the merge, and alert the user
to what's going on.

This situation may arise if you start a 'git notes merge' which results in
conflicts, and you then update the current notes ref (using for example
'git notes add/copy/amend/edit/remove/prune', 'git update-ref', etc.),
before you get around to resolving the notes conflicts and calling
'git notes merge --commit'.

We detect this situation by comparing the first parent of the partial merge
commit (which was created when the merge started) to the current value of the
merging notes ref (pointed to by the .git/NOTES_MERGE_REF symref).

If we don't fail in this situation, the notes merge commit would overwrite
the updated notes ref, thus losing the changes that happened in the meantime.

The patch includes a testcase verifying that we fail correctly in this
situation.

Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: List conflicting notes in notes merge... Johan Herland Tue, 9 Nov 2010 21:49:53 +0000 (22:49 +0100)

git notes merge: List conflicting notes in notes merge commit message

This brings notes merge in line with regular merge's behaviour.

This patch has been improved by the following contributions:
- Ævar Arnfjörð Bjarmason: Don't use C99 comments.

Thanks-to: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: Manual conflict resolution, part 2/2Johan Herland Tue, 9 Nov 2010 21:49:52 +0000 (22:49 +0100)

git notes merge: Manual conflict resolution, part 2/2

When the notes merge conflicts in .git/NOTES_MERGE_WORKTREE have been
resolved, we need to record a new notes commit on the appropriate notes
ref with the resolved notes.

This patch implements 'git notes merge --commit' which the user should
run after resolving conflicts in the notes merge worktree. This command
finalizes the notes merge by recombining the partial notes tree from
part 1 with the now-resolved conflicts in the notes merge worktree in a
merge commit, and updating the appropriate ref to this merge commit.

In order to correctly finalize the merge, we need to keep track of three
things:

- The partial merge result from part 1, containing the auto-merged notes.
This is now stored into a ref called .git/NOTES_MERGE_PARTIAL.
- The unmerged notes. These are already stored in
.git/NOTES_MERGE_WORKTREE, thanks to part 1.
- The notes ref to be updated by the finalized merge result. This is now
stored in a symref called .git/NOTES_MERGE_REF.

In addition to "git notes merge --commit", which uses the above details
to create the finalized notes merge commit, this patch also implements
"git notes merge --reset", which aborts the ongoing notes merge by simply
removing the files/directory described above.

FTR, "git notes merge --commit" reuses "git notes merge --reset" to remove
the information described above (.git/NOTES_MERGE_*) after the notes merge
have been successfully finalized.

The patch also contains documentation and testcases for the two new options.

This patch has been improved by the following contributions:
- Ævar Arnfjörð Bjarmason: Fix nonsense sentence in --commit description
- Sverre Rabbelier: Rename --reset to --abort

Thanks-to: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Thanks-to: Sverre Rabbelier <srabbelier@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: Manual conflict resolution, part 1/2Johan Herland Tue, 9 Nov 2010 21:49:51 +0000 (22:49 +0100)

git notes merge: Manual conflict resolution, part 1/2

Conflicts (that are to be resolved manually) are written into a special-
purpose working tree, located at .git/NOTES_MERGE_WORKTREE. Within this
directory, conflicting notes entries are stored (with conflict markers
produced by ll_merge()) using the SHA1 of the annotated object. The
.git/NOTES_MERGE_WORKTREE directory will only contain the _conflicting_
note entries. The non-conflicting note entries (aka. the partial merge
result) are stored in 'local_tree', and the SHA1 of the resulting commit
is written to 'result_sha1'. The return value from notes_merge() is -1.

The user is told to edit the files within the .git/NOTES_MERGE_WORKTREE
directory in order to resolve the conflicts.

The patch also contains documentation and testcases for the correct setup
of .git/NOTES_MERGE_WORKTREE.

The next part will recombine the partial notes merge result with the
resolved conflicts in .git/NOTES_MERGE_WORKTREE to produce the complete
merge result.

This patch has been improved by the following contributions:
- Jonathan Nieder: Use trace_printf(...) instead of OUTPUT(o, 5, ...)

Thanks-to: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

Documentation: Preliminary docs on 'git notes merge'Johan Herland Tue, 9 Nov 2010 21:49:50 +0000 (22:49 +0100)

Documentation: Preliminary docs on 'git notes merge'

This patch has been improved by the following contributions:
- Stephen Boyd: Use "automatically resolves" instead of "auto-resolves"
- Stephen Boyd: Remove unbalanced '('

Thanks-to: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: Add automatic conflict resolvers ... Johan Herland Sun, 14 Nov 2010 23:55:12 +0000 (00:55 +0100)

git notes merge: Add automatic conflict resolvers (ours, theirs, union)

The new -s/--strategy command-line option to 'git notes merge' allow the user
to choose how notes merge conflicts should be resolved. There are four valid
strategies to choose from:

1. "manual" (the default): This will let the user manually resolve conflicts.
This option currently fails with an error message. It will be implemented
properly in future patches.

2. "ours": This automatically chooses the local version of a conflict, and
discards the remote version.

3. "theirs": This automatically chooses the remote version of a conflict, and
discards the local version.

4. "union": This automatically resolves the conflict by appending the remote
version to the local version.

The strategies are implemented using the combine_notes_* functions from the
notes.h API.

The patch also includes testcases verifying the correct implementation of
these strategies.

This patch has been improved by the following contributions:
- Jonathan Nieder: Future-proof by always checking add_note() return value
- Stephen Boyd: Use test_commit
- Stephen Boyd: Use correct option name

Thanks-to: Jonathan Nieder <jrnieder@gmail.com>
Thanks-to: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

git notes merge: Handle real, non-conflicting notes... Johan Herland Sun, 14 Nov 2010 23:54:11 +0000 (00:54 +0100)

git notes merge: Handle real, non-conflicting notes merges

This continuation of the 'git notes merge' implementation teaches notes-merge
to properly do real merges between notes trees: Two diffs are performed, one
from $base to $remote, and another from $base to $local. The paths in each
diff are normalized to SHA1 object names. The two diffs are then consolidated
into a single list of change pairs to be evaluated. Each change pair consist
of:

- The annotated object's SHA1
- The $base SHA1 (i.e. the common ancestor notes for this object)
- The $local SHA1 (i.e. the current notes for this object)
- The $remote SHA1 (i.e. the to-be-merged notes for this object)

From the pair ($base -> $local, $base -> $remote), we can determine the merge
result using regular 3-way rules. If conflicts are encountered in this
process, we fail loudly and exit (conflict handling to be added in a future
patch), If we can complete the merge without conflicts, the resulting
notes tree is committed, and the current notes ref updated.

The patch includes added testcases verifying that we can successfully do real
conflict-less merges.

This patch has been improved by the following contributions:
- Jonathan Nieder: Future-proof by always checking add_note() return value
- Stephen Boyd: Use test_commit
- Jonathan Nieder: Use trace_printf(...) instead of OUTPUT(o, 5, ...)
- Junio C Hamano: fixup minor style issues

Thanks-to: Jonathan Nieder <jrnieder@gmail.com>
Thanks-to: Stephen Boyd <bebarino@gmail.com>
Thanks-to: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>