From: Junio C Hamano Date: Mon, 22 Dec 2014 20:26:38 +0000 (-0800) Subject: Merge branch 'jc/refer-to-t-readme-from-submitting-patches' X-Git-Tag: v2.3.0-rc0~74 X-Git-Url: https://www.git.lorimer.id.au/gitweb.git/diff_plain/63296d583ca107b3f590c3a09be9b3670a2c1afb?hp=168ab99d4c0a3587cee18ef8300f78d4c4344a66 Merge branch 'jc/refer-to-t-readme-from-submitting-patches' * jc/refer-to-t-readme-from-submitting-patches: t/README: justify why "! grep foo" is sufficient SubmittingPatches: refer to t/README for tests --- diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index fa71b5f0b6..e3c942e579 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -57,7 +57,8 @@ change, the approach taken by the change, and if relevant how this differs substantially from the prior version, are all good things to have. -Make sure that you have tests for the bug you are fixing. +Make sure that you have tests for the bug you are fixing. See +t/README for guidance. When adding a new feature, make sure that you have new tests to show the feature triggers the new behaviour when it should, and to show the diff --git a/t/README b/t/README index 9952261299..d5bb0c9aa1 100644 --- a/t/README +++ b/t/README @@ -418,7 +418,8 @@ Don't: dies in an unexpected way (e.g. segfault). On the other hand, don't use test_must_fail for running regular - platform commands; just use '! cmd'. + platform commands; just use '! cmd'. We are not in the business + of verifying that the world given to us sanely works. - use perl without spelling it as "$PERL_PATH". This is to help our friends on Windows where the platform Perl often adds CR before